-
Notifications
You must be signed in to change notification settings - Fork 17
Use Uint8Array.fromBase64 instead of atob #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ECMAScript now has base64 -> Uint8Array conversion function in the standard. Let's just use it instead of relying on DOM's atob.
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
As of 2025-07-01 It is currently staged, and expected to become available quite soon, see https://crbug.com/42204568:
So the failing v8 build should be fixed around that time, then we can merge it from my side. (Not sure about SpiderMonkey, how's availability there?) |
|
This should be working now in d8 since the |
|
Ah, too early still. While it landed in d8, not yet in Chrome... |
Shipped in Firefox 133. https://bugzilla.mozilla.org/show_bug.cgi?id=1917885 |
|
Looks like indeed this is no longer called / used: https://github.com/search?q=repo%3AWebKit%2FJetStream%20base64ToArrayBuffer&type=code I guess we could just remove it then? |
|
The function |
|
Let's do that in an (optional) follow-up and for now just merge this PR. Let me close and re-open to trigger CI/actions and see if it now works in Chrome (it should, as M140 is already stable since a while). |
ECMAScript now has base64 -> Uint8Array conversion function in the standard. Let's just use it instead of relying on DOM's atob.